[coreboot-gerrit] Change in ...coreboot[master]: lib/bootblock: Sanitize CMOS after bootblock_*_early_init()

[Thomas Heijligen (Code Review)]

Hello Nico Huber,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/31349

to review the following change.

Change subject: lib/bootblock: Sanitize CMOS after bootblock_*_early_init()
......................................................................

lib/bootblock: Sanitize CMOS after bootblock_*_early_init()

CMOS isn't used that early, but the chipset initialization may be
required to access it.

In one instance, Intel Apollo Lake, the sanitize_cmos() function
seems to hang if called before bootblock_soc_early_init(). The
missing step is fast_spi_early_init(). But even without, one might
expect sanitize_cmos() to return eventually (it didn't within
about 20min).

Change-Id: I6e1a029e4be7e109be43a3dad944bd7e05ea1f02
Signed-off-by: Nico Huber 
---
M src/lib/bootblock.c
1 file changed, 3 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/31349/1

diff --git a/src/lib/bootblock.c b/src/lib/bootblock.c
index f2ada52..6b9ecbf 100644
--- a/src/lib/bootblock.c
+++ b/src/lib/bootblock.c
@@ -41,12 +41,12 @@
    			      timestamps[i].entry_stamp);
    }

-	sanitize_cmos();
-	cmos_post_init();
-
    bootblock_soc_early_init();
    bootblock_mainboard_early_init();

+	sanitize_cmos();
+	cmos_post_init();
+
    if (IS_ENABLED(CONFIG_BOOTBLOCK_CONSOLE)) {
    	console_init();
    	exception_init();