Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22932 )
Change subject: mb/lenovo/x200: Use lower C-states on battery
......................................................................
Patch Set 15:
(2 comments)
It would be better if this information was passed via devicetree and then checked if both CPU and SB support the C-state. For now this may be good enough?
https://review.coreboot.org/c/coreboot/+/22932/15/src/cpu/intel/speedstep/ac...
File src/cpu/intel/speedstep/acpi.c:
https://review.coreboot.org/c/coreboot/+/22932/15/src/cpu/intel/speedstep/ac...
PS15, Line 159: acpigen_emit_namestring("PWRS")
Does PWRS exist on all callers?
PWRS is in the GNVS of i82810{g,i,j}x which are all the platforms using this code.
https://review.coreboot.org/c/coreboot/+/22932/15/src/cpu/intel/speedstep/ac...
PS15, Line 163: num_bat_cstates
Always true?
Can be 0, just like num_cstates can be 0.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/22932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf32ee2ac3272fee74ce3b92b2c537cb722991d7
Gerrit-Change-Number: 22932
Gerrit-PatchSet: 15
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Duncan Laurie
dlaurie@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 13 Oct 2019 18:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment