Attention is currently required from: Martin L Roth, Nicholas Chin.
Nico Huber has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/83185?usp=email )
Change subject: util/autoport: Add CC-PDDC SPDX header to empty files
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File util/autoport/main.go:
https://review.coreboot.org/c/coreboot/+/83185/comment/1c3fd224_6cfbcaa1?usp... :
PS4, Line 245: }
Suggestion: You could turn it around and have a new function that
calls Add_SPDX() and then adds the comment, to avoid the if, e.g.
Add_Empty_File(name string).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83185?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5fdf0c80443a79c082b3d0418d16cd858782b2c9
Gerrit-Change-Number: 83185
Gerrit-PatchSet: 4
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Comment-Date: Wed, 11 Sep 2024 22:30:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes