Pavel Sayekat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33842 )
Change subject: src/superio/nuvoton: Add support for NCT5539D ......................................................................
Patch Set 8:
(4 comments)
Patch Set 3:
(4 comments)
Will check against the datasheet later. What did you base this on?
NCT6791D used as reference.
https://review.coreboot.org/#/c/33842/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33842/3//COMMIT_MSG@7 PS3, Line 7: src/superio/nuvoton/common/early_serial.c: Add symbol to select COM port for NCT5539D : : src/superio/nuvoton/Makefile.inc: Add definition for NCT5539D
Remove these lines
Ack
https://review.coreboot.org/#/c/33842/3//COMMIT_MSG@11 PS3, Line 11: src/superio/nuvoton: Add support for NCT5539D
Keep this line
Done
https://review.coreboot.org/#/c/33842/3/src/superio/nuvoton/Makefile.inc File src/superio/nuvoton/Makefile.inc:
https://review.coreboot.org/#/c/33842/3/src/superio/nuvoton/Makefile.inc@27 PS3, Line 27: subdirs-$(CONFIG_SUPERIO_NUVOTON_NCT5539D) += nct5539d
While the order does not matter, I would prefer to keep this list's numerical order. […]
Done
https://review.coreboot.org/#/c/33842/3/src/superio/nuvoton/nct5539d/nct5539... File src/superio/nuvoton/nct5539d/nct5539d.h:
https://review.coreboot.org/#/c/33842/3/src/superio/nuvoton/nct5539d/nct5539... PS3, Line 32: /*GPIO, RI PSOUT Wake-Up Status*/
missing spacing on this comment and the next one
Done