Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48677 )
Change subject: kconfig: allow for optional source with osource
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48677/1/src/soc/intel/common/baseco...
File src/soc/intel/common/basecode/Kconfig:
https://review.coreboot.org/c/coreboot/+/48677/1/src/soc/intel/common/baseco...
PS1, Line 9: source "src/soc/intel/common/basecode/*/*/Kconfig"
If these lines are dead, why not remove them?
Guess we could do that too... didn't dig in too much to see if this was being placed by some external submodule or something...
I think we're in the clear tho. Will update.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48677
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71fbcfc1807e7398da250ddf1e47f6530345e0b5
Gerrit-Change-Number: 48677
Gerrit-PatchSet: 1
Gerrit-Owner: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Thu, 17 Dec 2020 20:56:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment