Attention is currently required from: Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48383 )
Change subject: mb/fujitsu/d3410-b1: Add new mainboard ......................................................................
Patch Set 6:
(53 comments)
File src/mainboard/fujitsu/d3410-b1/gpio.c:
https://review.coreboot.org/c/coreboot/+/48383/comment/5711fc4c_75620ce5 PS6, Line 13: _PAD_CFG_STRUCT(GPP_A0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/96ddd2e5_94091ae9 PS6, Line 14: _PAD_CFG_STRUCT(GPP_A1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ac08aff2_593a865b PS6, Line 15: _PAD_CFG_STRUCT(GPP_A2, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3fab7540_47e61bbf PS6, Line 16: _PAD_CFG_STRUCT(GPP_A3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/c16e9240_106cc2ba PS6, Line 17: _PAD_CFG_STRUCT(GPP_A4, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/01a44e51_16a05850 PS6, Line 18: _PAD_CFG_STRUCT(GPP_A5, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ecbe55b1_dadb7fc5 PS6, Line 19: _PAD_CFG_STRUCT(GPP_A6, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a254124e_6c5cb799 PS6, Line 20: _PAD_CFG_STRUCT(GPP_A7, PAD_FUNC(NF1) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/7cea9d67_b245b5dd PS6, Line 21: _PAD_CFG_STRUCT(GPP_A8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/dc2fdeec_3639c7ba PS6, Line 22: _PAD_CFG_STRUCT(GPP_A9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/320de2b8_e5fb8050 PS6, Line 23: _PAD_CFG_STRUCT(GPP_A10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/d2078032_aa0a1dc7 PS6, Line 24: _PAD_CFG_STRUCT(GPP_A11, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/f63ac438_d84e6175 PS6, Line 25: _PAD_CFG_STRUCT(GPP_A13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/d529f8ef_8f70ae95 PS6, Line 26: _PAD_CFG_STRUCT(GPP_A15, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b1ff02e0_ecf45fb5 PS6, Line 29: _PAD_CFG_STRUCT(GPP_A23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/5fa914a2_95600e01 PS6, Line 33: _PAD_CFG_STRUCT(GPP_B12, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/d7cf7150_06e78df7 PS6, Line 34: _PAD_CFG_STRUCT(GPP_B13, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/e5a442c4_6f320778 PS6, Line 35: _PAD_CFG_STRUCT(GPP_B14, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/0822d2de_0d6e0724 PS6, Line 37: _PAD_CFG_STRUCT(GPP_B18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ad422472_a5d78851 PS6, Line 38: _PAD_CFG_STRUCT(GPP_B22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a0133844_465da97b PS6, Line 39: _PAD_CFG_STRUCT(GPP_B23, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/bd09bcfa_1fb068e4 PS6, Line 44: _PAD_CFG_STRUCT(GPP_C0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/8ca228c9_0e378c54 PS6, Line 45: _PAD_CFG_STRUCT(GPP_C1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/43bf300c_29dabdbb PS6, Line 46: _PAD_CFG_STRUCT(GPP_C2, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/e9e1db84_bf447222 PS6, Line 47: _PAD_CFG_STRUCT(GPP_C3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/1f10f6f8_de6b9af8 PS6, Line 48: _PAD_CFG_STRUCT(GPP_C4, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_RX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/62639e10_5be11c84 PS6, Line 49: _PAD_CFG_STRUCT(GPP_C5, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/7bb33726_f7f0c776 PS6, Line 50: _PAD_CFG_STRUCT(GPP_C8, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/2b4d0a3e_a8767344 PS6, Line 51: _PAD_CFG_STRUCT(GPP_C9, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/c44bc35e_10663935 PS6, Line 52: _PAD_CFG_STRUCT(GPP_C22, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b9c65ad8_75aec499 PS6, Line 57: _PAD_CFG_STRUCT(GPP_D14, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/b588b47c_85f47873 PS6, Line 58: _PAD_CFG_STRUCT(GPP_D15, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/23eca670_1c1900dd PS6, Line 59: _PAD_CFG_STRUCT(GPP_D18, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(UP_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/c6e6fa82_010a3560 PS6, Line 62: _PAD_CFG_STRUCT(GPP_E8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/5d590158_b46ce40d PS6, Line 63: _PAD_CFG_STRUCT(GPP_E9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/9d30b0cf_182d7485 PS6, Line 64: _PAD_CFG_STRUCT(GPP_E10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a6296495_8c80393e PS6, Line 65: _PAD_CFG_STRUCT(GPP_E11, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/9f34f4f0_c92fc437 PS6, Line 66: _PAD_CFG_STRUCT(GPP_E12, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/391a92dd_f7012023 PS6, Line 69: _PAD_CFG_STRUCT(GPP_F15, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/90b59170_604d1b7b PS6, Line 70: _PAD_CFG_STRUCT(GPP_F16, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/49dbc85c_c40a55f4 PS6, Line 79: _PAD_CFG_STRUCT(GPP_H0, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_DISABLE) | (1 << 1), PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/2e9b2cc7_24d6c060 PS6, Line 82: _PAD_CFG_STRUCT(GPP_H12, PAD_FUNC(GPIO) | PAD_RESET(PLTRST) | PAD_BUF(TX_RX_DISABLE) | 1, PAD_PULL(DN_20K)), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/7d9f2d3d_09f2ac39 PS6, Line 105: _PAD_CFG_STRUCT(GPP_I0, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a1c20915_ba54d223 PS6, Line 106: _PAD_CFG_STRUCT(GPP_I1, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/98f5744c_7e4d5b67 PS6, Line 107: _PAD_CFG_STRUCT(GPP_I2, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/d7691467_eb8413ae PS6, Line 108: _PAD_CFG_STRUCT(GPP_I3, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a09d904d_36c0d9e6 PS6, Line 109: _PAD_CFG_STRUCT(GPP_I5, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/ca20a882_99f18e7f PS6, Line 110: _PAD_CFG_STRUCT(GPP_I6, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/3e54f7e8_fbdeef1d PS6, Line 111: _PAD_CFG_STRUCT(GPP_I7, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/258433ac_69f9f27d PS6, Line 112: _PAD_CFG_STRUCT(GPP_I8, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/475d44dc_3546d82b PS6, Line 113: _PAD_CFG_STRUCT(GPP_I9, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/48383/comment/a84a3ac4_09258f7b PS6, Line 114: _PAD_CFG_STRUCT(GPP_I10, PAD_FUNC(NF1) | PAD_RESET(PLTRST) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
File src/mainboard/fujitsu/d3410-b1/romstage.c:
https://review.coreboot.org/c/coreboot/+/48383/comment/037d132a_c447ed59 PS6, Line 18: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)