Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32527 )
Change subject: soc/intel/cannonlake: Dump ME f/w version and status information.
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/#/c/32527/5/src/soc/intel/cannonlake/me.c
File src/soc/intel/cannonlake/me.c:
https://review.coreboot.org/#/c/32527/5/src/soc/intel/cannonlake/me.c@32
PS5, Line 32: BIOS_HOST_ADD
ADDR instead of ADD to avoid confusion?
Actually, my bad, these (*_ADDR) are already defined in cse.h. Removing these instead.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibeb3a2a85cd84c9baa45f90f20a3dcf69f7d5646
Gerrit-Change-Number: 32527
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Assignee: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Lijian Zhao
lijian.zhao@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 17 May 2019 22:02:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lijian Zhao
lijian.zhao@intel.com
Gerrit-MessageType: comment