[coreboot-gerrit] [M] Change in coreboot[master]: Revert "util/ifdtool: Add option to create FMAP template"

[Maximilian Brune (Code Review)]

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Matt DeVillier, Stefan Reinauer, Kapil Porwal, Angel Pons, Lean Sheng Tan.

Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 )

Change subject: Revert "util/ifdtool: Add option to create FMAP template"
......................................................................

Patch Set 2:

(1 comment)

Commit Message:

https://review.coreboot.org/c/coreboot/+/74692/comment/745276ba_cca21da0 
PS2, Line 11: Above commit inserts multiple IFD regions not present into the default
            : FMAP template, some of which overlap, resulting in far less space
            : available for BIOS region / CBFS.
I don't understand. why "not present"? It only inserts IFD regions that are present in the IFD.
The basic Idea is that all IFD regions (except BIOS region) are mapped to the FMAP to prevent overlaps. That can for example happen by increasing the CBFS_SIZE too much and therefore unintentionally overlapping the IFD/blob regions without noticing.
Did you have issues with an IFD on a board? Was the IFD faulty somehow?