Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31754 )
Change subject: arch/x86: Optimise PCI IO config accessor ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/31754/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31754/2//COMMIT_MSG@10 PS2, Line 10: in case dev is not immediate constant. How is that achieved? Is there any information for the compiler added? or is this just what current GCC can optimize better?
https://review.coreboot.org/#/c/31754/2/src/arch/x86/include/arch/pci_io_cfg... File src/arch/x86/include/arch/pci_io_cfg.h:
https://review.coreboot.org/#/c/31754/2/src/arch/x86/include/arch/pci_io_cfg... PS2, Line 22: u16 Please don't mix short uXX names with standard uintXX_t in one file.
https://review.coreboot.org/#/c/31754/2/src/arch/x86/include/arch/pci_io_cfg... PS2, Line 24: << spaces around << ? (parents unnecessary)