Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37262 )
Change subject: util: cbfstool: Check alignment at build time
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37262/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/37262/6//COMMIT_MSG@20
PS6, Line 20: FMAP%@0x1000 0x800
alignment actually applies to both offset and size but well, if you think that would make more sense […]
No, I think it should apply to both offset and size, but I still think about it as mostly an offset thing and the size is just sort of a consequence. I don't know. I would've put it behind the offset but that doesn't mean that that necessarily makes more sense to everyone, so pick what you feel is best.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37262
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26b394590c28667a4afcd521c7caa2009b5b98a9
Gerrit-Change-Number: 37262
Gerrit-PatchSet: 8
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 28 Nov 2019 05:53:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment