Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39002 )
Change subject: lib/edid_fill_fb: Support multiple framebuffers
......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/39002/6/src/include/framebuffer_inf...
File src/include/framebuffer_info.h:
https://review.coreboot.org/c/coreboot/+/39002/6/src/include/framebuffer_inf...
PS6, Line 37: bool fb_fill_framebuffer_info(struct fb_info *info,
It's only used in xgifb_modeset. […]
removed.
https://review.coreboot.org/c/coreboot/+/39002/6/src/lib/edid_fill_fb.c
File src/lib/edid_fill_fb.c:
PS6:
The file is not much about EDID anymore, rename?
done in CB:39431
https://review.coreboot.org/c/coreboot/+/39002/6/src/lib/edid_fill_fb.c@36
PS6, Line 36: static struct fb_info *list;
Why not use <list. […]
Done
https://review.coreboot.org/c/coreboot/+/39002/6/src/lib/edid_fill_fb.c@96
PS6, Line 96: info->valid = true;
yes, if it doesn't pass the pre check: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39002
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7264c2ea2f72f36adfd26f26b00e3ce172133621
Gerrit-Change-Number: 39002
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Alexandru Gagniuc
alexandrux.gagniuc@intel.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@intel.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 10 Mar 2020 15:46:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment