Balázs Vinarz has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30899 )
Change subject: AGESA/binaryPI: Drop invalid AMD_AGESA_BOLTON
......................................................................
Patch Set 4:
Patch Set 4:
Bolton is more or less Hudson with an updated XHCI controller; as far as I remember the Hudson code was also valid for Bolton, but needed some Kconfig settings so that the right blob for the XHCI controller is used. So if I had seen the patch before it got merged, I'd at least -1ed it.
This patch breaks XHCI for fam15tn/fam15rl devices that have a Bolton FCH
XHCI was non-working anyway (for me at least). I was just disappointed, because I had to work on the port again.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic3cb9ada2d4f14b49f6ad54c58e6b950a1732b70
Gerrit-Change-Number: 30899
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Balázs Vinarz
vinibali1@gmail.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 21 Jan 2019 12:34:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment