Attention is currently required from: Kevin Chiu, Nick Vaccaro, Shon Wang.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59288 )
Change subject: mb/google/brya/var/vell: Generate LP5 RAM ID
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Patchset:
PS2:
LGTM (I don't have CR+2 yet).
File src/mainboard/google/brya/variants/vell/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59288/comment/ec2ee9cf_f8095c2a
PS2, Line 1: # SPDX-License-Identifier: GPL-2.0-or-later
: # This is an auto-generated file. Do not edit!!
Unrelated to this change: it's a bit annoying that the number of #'s doesn't match the template. I'll upload a CL to fix the templates.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59288
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I49745948ebdb25fd98e285defd75714f80271968
Gerrit-Change-Number: 59288
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Shon Wang
shon.wang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 05:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment