8 Apr
2021
8 Apr
'21
7:58 p.m.
Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37392 )
Change subject: cpu/x86/smm/smm_stub: Add x86_64 support ......................................................................
Patch Set 8:
(1 comment)
File src/cpu/x86/smm/smm_stub.S:
https://review.coreboot.org/c/coreboot/+/37392/comment/38602d6f_25f23bf4 PS8, Line 153: subl $0xc, %esp This seems suspicious
--
To view, visit https://review.coreboot.org/c/coreboot/+/37392
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26300492e4be62ddd5d80525022c758a019d63a1
Gerrit-Change-Number: 37392
Gerrit-PatchSet: 8
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Eugene Myers cedarhouse1@comcast.net
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Bill XIE persmule@hardenedlinux.org
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-CC: ron minnich rminnich@gmail.com
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 19:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment