Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39321 )
Change subject: ec/google/chromeec: Fix dev ops for chromeec
......................................................................
Patch Set 4:
Patch Set 4:
What about non-LPC ECs? Don't they lose the ACPI tables this way?
ChromeECs have all been using LPC(eSPI). At least, at this point, I don't think we have any ChromeEC which is non-LPC(eSPI) based.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39321
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a242f4b15603f957e0e81d121e5766fccf3c28d
Gerrit-Change-Number: 39321
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 05 Mar 2020 16:31:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment