HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32533 )
Change subject: sb/{ICH7,NM10,PCH}: Use common watchdog_off function
......................................................................
Patch Set 12:
(2 comments)
Thank you
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi...
File src/southbridge/intel/common/Makefile.inc:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/Makefi...
PS12, Line 55: ramstage-$(CONFIG_SOUTHBRIDGE_INTEL_COMMON_WATCHDOG) += watchdog.c
It's placed inside `ifeq ($(CONFIG_SOUTHBRIDGE_INTEL_COMMON),y)` […]
Done
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h
File src/southbridge/intel/common/tco.h:
https://review.coreboot.org/#/c/32533/12/src/southbridge/intel/common/tco.h@...
PS12, Line 25: #define TCO_TMR_HLT (1 << 11)
indent?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32533
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I704780b6ae7238560dcb72fc027addc1089e0674
Gerrit-Change-Number: 32533
Gerrit-PatchSet: 12
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Guckian
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 05 May 2019 11:25:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment