Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33116 )
Change subject: Kconfig: Set default value for CACHE_RELOCATED_RAMSTAGE_OUTSIDE_CBMEM
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/33116/7/src/Kconfig
File src/Kconfig:
https://review.coreboot.org/#/c/33116/7/src/Kconfig@252
PS7, Line 252: default n if !ENABLE_STAGE_RAMSTAGE
This is already default n implicitly, so what does this line add? […]
i was just trying to make sure all root dependent kconfig doesn't get default select. I understand your point, do you have some suggestion to make those root dependent config uncheck when root is not select ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33116
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45e894ad335a4661cc7916b3768e1614a038b31c
Gerrit-Change-Number: 33116
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 08 Jun 2019 04:11:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment