Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37326 )
Change subject: AGESA,binaryPI: Split romstage_main() to BSP and AP parts
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37326/1/src/drivers/amd/agesa/romst...
File src/drivers/amd/agesa/romstage.c:
https://review.coreboot.org/c/coreboot/+/37326/1/src/drivers/amd/agesa/romst...
PS1, Line 56: if (initial_apic_id == 0) {
Good question. […]
CB:18624 has some history, it was originally called cpu_init_detected. It could be that AGESA uses it to detect if we re-entered romstage another time after system reset. If that still happens, it's a bit nasty for verstage and we might need to move the test to bootblock.
It needs some further investigation but would be followup and not change this commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37326
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id013b165f1345509fe6b74cef2bf8c3b420f84a4
Gerrit-Change-Number: 37326
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 29 Nov 2019 23:25:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment