Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43801 )
Change subject: mb/google/dedede/var/madoo: Add audio support (ALC5682, MX98360A)
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43801/1/src/mainboard/google/dedede...
PS1, Line 77: chip drivers/generic/max98357a
Please fix the indent
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43801
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe3d878b1058bfae4143d96be854884e61394ad5
Gerrit-Change-Number: 43801
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Comment-Date: Fri, 24 Jul 2020 09:35:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment