Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46555 )
Change subject: soc/intel/xeon_sp/{skx,cpx}: Add txt_get_chipset_dpr callback
......................................................................
Patch Set 8:
Patch Set 7: Code-Review+2
It would be nice to avoid adding two copies of the same function.
CB:46478 addresses the duplicate code. It would be nice to land that for these changes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46555
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id824324325d05b52fb2b9ced04fd3539cc37bd55
Gerrit-Change-Number: 46555
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marc Jones
marc@marcjonesconsulting.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 28 Oct 2020 19:50:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment