22 Feb
2019
22 Feb
'19
1:39 a.m.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31511 )
Change subject: AGESA: Move heap_status_name() implementation ......................................................................
Patch Set 3:
(1 comment)
Any idea why Proc/CPU/Family was also being included? Removing it seems unrelated.
https://review.coreboot.org/#/c/31511/2/src/vendorcode/amd/agesa/common/debu... File src/vendorcode/amd/agesa/common/debug_util.c:
https://review.coreboot.org/#/c/31511/2/src/vendorcode/amd/agesa/common/debu... PS2, Line 2: #include <AGESA. I'm not seeing why this is necessary. (Also, BTW I believe in all cases where you include AGESA.h, you also pick up AMD.h.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/31511
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iae86d6631d7a6ba6ea2588a53b292b435dfd7861
Gerrit-Change-Number: 31511
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Feb 2019 00:39:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment