Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34516 )
Change subject: mb/google/kukui: Support eDP panels via PS8640 ......................................................................
Patch Set 40:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... File src/mainboard/google/kukui/Kconfig:
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... PS40, Line 49: select DRIVER_PARADE_PS8640 if KUKUI_HAS_PS8640 nit: at that point might as well just do
select DRIVER_PARADE_PS8640 if BOARD_GOOGLE_JACUZZI
here and skip the extra option?
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... File src/mainboard/google/kukui/panel_ps8640.c:
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... PS40, Line 60: 8 nit: I'd write I2C addresses as 0x08 since that's how you usually see them on schematics
https://review.coreboot.org/c/coreboot/+/34516/40/src/mainboard/google/kukui... PS40, Line 72: ps8640_panel.edid.mode.name = mode_name; Why does ps8640_get_edid() not do that? Shouldn't we rather add it to that function?