Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44703 )
Change subject: soc/mediatek/mt8192: Do EMI init before dram calibration
......................................................................
Patch Set 48:
Patch Set 46:
Hi Xi Chen, given we are reviewing the memory patches, can you take this chance to figure out what parts can be moved to common/ so we can share them (for example 8195) in future?
Even better if you can revise with 8183 at the same time, or start with 'finding dram calibration code that is common for 83/92 and move them to common/'
83 and 92 has different SoC architecture. It is hard to have DRAM code in common.
DRAM driver team is trying to figure out a way to smoothen the upstream process on 95.
I will update to you once they have the conclusion.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b778698a09c999252fef3153ac1e869ea9d90cd
Gerrit-Change-Number: 44703
Gerrit-PatchSet: 48
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 17 Dec 2020 06:04:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment