1 Mar
2019
1 Mar
'19
7:18 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31616 )
Change subject: superio/ite/common: add option for enabling 5 FANs ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Thank you, this looks much better already.
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h File src/superio/ite/common/env_ctrl.h:
https://review.coreboot.org/#/c/31616/4/src/superio/ite/common/env_ctrl.h@62 PS4, Line 62: ? (0x84 + ((x)-4) * 2) \ : : (0x10 + ((x)-1)) I would still prefer this to be aligned up with the other register offsets :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/31616
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icd60a16b6b5583a3b981bdc220aac472c2a8f40f
Gerrit-Change-Number: 31616
Gerrit-PatchSet: 4
Gerrit-Owner: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel krystian.hebel@3mdeb.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Mar 2019 15:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment