Attention is currently required from: Ravi kumar, Shelley Chen, Paul Menzel, Ravi Kumar Bokka, Julius Werner.
mturney mturney has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support
......................................................................
Patch Set 39:
(4 comments)
File src/mainboard/google/herobrine/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/45206/comment/5750fb83_43ec9001
PS22, Line 1:
i will address this comment, once discuss with internally
Followed model use by trogdor, please confirm this is what you intended.
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/45206/comment/addc26a1_cbc064fb
PS32, Line 3: TROGDOR
HEROBRINE
Ack
https://review.coreboot.org/c/coreboot/+/45206/comment/29f77836_27c13d21
PS32, Line 4: TROGDOR
HEROBRINE
Ack
https://review.coreboot.org/c/coreboot/+/45206/comment/f6f7a02f_344f8b83
PS32, Line 11: TROGDOR
HEROBRINE
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 39
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Ravi kumar
rbokka@codeaurora.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 24 Mar 2021 00:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Shelley Chen
shchen@google.com
Comment-In-Reply-To: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-MessageType: comment