Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45103 )
Change subject: drivers/ipmi: Add CONFIG_IPMI_KCS_TIMEOUT_MS for IPMI KCS timeout value ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45103/2/src/drivers/ipmi/Kconfig File src/drivers/ipmi/Kconfig:
https://review.coreboot.org/c/coreboot/+/45103/2/src/drivers/ipmi/Kconfig@42 PS2, Line 42: The timeout time for a single KCS IO in the unit of 100 microseconds.
If possible, please normalize the unit to μs or ms, and add the unit to the variable name.
Done
https://review.coreboot.org/c/coreboot/+/45103/2/src/drivers/ipmi/ipmi_kcs.c File src/drivers/ipmi/ipmi_kcs.c:
https://review.coreboot.org/c/coreboot/+/45103/2/src/drivers/ipmi/ipmi_kcs.c... PS2, Line 43: } while (timeout--);
Please rewrite using `wait_us()` or `wait_ms()` from `src/include/timer.h`.
Done