Attention is currently required from: Jason Glenesk, Raul Rangel, Bao Zheng, Marshall Dawson, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50232 )
Change subject: soc/amd/picasso: Fix copy-paste error in macro definitions
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/picasso/include/soc/data_fabric.h:
https://review.coreboot.org/c/coreboot/+/50232/comment/f7a72a78_52700649
PS1, Line 68: DF_IND_CFG_ACC_FUN_MASK
this should be DF_IND_CFG_ACC_FUN_SHIFT and not the _MASK
Oof, done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50232
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78370e17d2396f77ab820771f93cf15957bcf674
Gerrit-Change-Number: 50232
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Bao Zheng
zheng.bao@amd.corp-partner.google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 02 Feb 2021 17:27:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment