1 Oct
2018
1 Oct
'18
9:43 a.m.
Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/28834 )
Change subject: mc_apl1: Set up SPI OPCODE menu before locking ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28834/1/src/mainboard/siemens/mc_apl1/mainbo... File src/mainboard/siemens/mc_apl1/mainboard.c:
https://review.coreboot.org/#/c/28834/1/src/mainboard/siemens/mc_apl1/mainbo... PS1, Line 46: Byte Program should that be 'Page Program'?
--
To view, visit https://review.coreboot.org/28834
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf0619ff0610c00325f03d13b6794aee8a62504
Gerrit-Change-Number: 28834
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Mario Scheithauer mario.scheithauer@siemens.com
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 01 Oct 2018 07:43:11 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes