Attention is currently required from: Jian Tong, Karthik Ramasubramanian, Wentao Qin.
Paul Menzel has posted comments on this change by Jian Tong. ( https://review.coreboot.org/c/coreboot/+/83290?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/var/lotso: Tune I2C frequency for 400 kHz
......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83290/comment/a350cea5_fed2d52a?usp... :
PS5, Line 7: for 400 kHz
Looking at the numbers, than this should be: … to be less than 400 kHz?
https://review.coreboot.org/c/coreboot/+/83290/comment/c667f99a_1bca7aa6?usp... :
PS5, Line 17: HW: Change R8409/R8411 to 33ohm.
Sorry, I do not understand this comment. Can you please elaborate?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I985837b1b80e973f148529b446905580c0f95e98
Gerrit-Change-Number: 83290
Gerrit-PatchSet: 5
Gerrit-Owner: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 12:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No