Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31107 )
Change subject: nb/intel/i945: No need to redo stuff already done at bootblock
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31107/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31107/2//COMMIT_MSG@7
PS2, Line 7: nb/intel/i945: No need to redo stuff already done at bootblock
This should be a statement about the change not the issue. e.g.
Remove initialization already done at bootblock
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31107
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f34380b0e700cf60688ad58465f9cb0aeda0928
Gerrit-Change-Number: 31107
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 26 Jan 2019 16:13:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment