Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56106 )
Change subject: vc/mediatek/mt8195: Enable DRAM Vcore DVFS settings ......................................................................
Patch Set 8:
(3 comments)
File src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/0ed9541d_b5dd0abf PS5, Line 275: print("Vio18 = %d\n", dramc_get_vio18_voltage());
Why is this removed?
vio18 is fixed at 1.8 volts, it will not be adjusted during dram init, and pmic does not provide a driver for reading and writing vio18, so remove this line.
File src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/12361572_0e9b51fe PS7, Line 275: print("Vio18 = %d\n", dramc_get_vio18_voltage());
please explain why you have to remove this in this patch.
vio18 is fixed at 1.8 volts, it will not be adjusted during dram init, and pmic does not provide a driver for reading and writing vio18, so remove this line.
File src/vendorcode/mediatek/mt8195/dramc/dramc_top.c:
https://review.coreboot.org/c/coreboot/+/56106/comment/88594f93_f057b237 PS7, Line 356: d
%u (vcore is unsigned)
Done