Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35905 )
Change subject: mediatek/mt8183: keep XO_SOC always in Full Power Mode
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35905/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35905/1//COMMIT_MSG@11
PS1, Line 11: the random failure of suspend resume test.
Please add more details about that failure (summary of some bug report). Also, how much more power is now used in suspend?
https://review.coreboot.org/c/coreboot/+/35905/1/src/soc/mediatek/mt8183/rtc...
File src/soc/mediatek/mt8183/rtc.c:
https://review.coreboot.org/c/coreboot/+/35905/1/src/soc/mediatek/mt8183/rtc...
PS1, Line 416: * Also keep XO_SOC always in Full Power Mode.
Mark this as FIXME? Reference some bug URL?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6cf8a9968cbdd2a5865aa2fd158a1ba0beb90f5
Gerrit-Change-Number: 35905
Gerrit-PatchSet: 1
Gerrit-Owner: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 10 Oct 2019 15:21:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment