Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/23563
Change subject: ec/google/chromeec: Remove wake flag from keyboard IRQ ......................................................................
ec/google/chromeec: Remove wake flag from keyboard IRQ
The keyboard IRQ was changed to ExclusiveAndWake in order to support waking from suspend-to-idle (S0ix) with commit f611fcfacac5be14a51e04ae4d0b1e25cd5439c0 (http://review.coreboot.org/11712)
However this is triggering a kernel panic on Windows 10 because it apparently does not like legacy devices interrupts to to be set as wake capable.
This change is no longer necessary because the linux kernel was changed to always treat the keyboard as wake capable: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/dr...
Change-Id: I26e27de68095f8d176108f39312338522d7cfba0 Signed-off-by: Duncan Laurie dlaurie@chromium.org --- M src/ec/google/chromeec/acpi/superio.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/23563/1
diff --git a/src/ec/google/chromeec/acpi/superio.asl b/src/ec/google/chromeec/acpi/superio.asl index 0f06e30..7cd6523 100644 --- a/src/ec/google/chromeec/acpi/superio.asl +++ b/src/ec/google/chromeec/acpi/superio.asl @@ -151,7 +151,7 @@ #ifdef SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ #else - IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} + IRQ (Edge, ActiveHigh, Exclusive) {1} #endif })
@@ -163,7 +163,7 @@ #ifdef SIO_EC_PS2K_IRQ SIO_EC_PS2K_IRQ #else - IRQ (Edge, ActiveHigh, ExclusiveAndWake) {1} + IRQ (Edge, ActiveHigh, Exclusive) {1} #endif } EndDependentFn ()