Attention is currently required from: Furquan Shaikh, Michael Niewöhner, Kyösti Mälkki, Patrick Rudolph, Aaron Durbin.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51328 )
Change subject: pciexp_device: Rewrite LTR configuration
......................................................................
Patch Set 2:
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/51328/comment/8a8088c4_df2717b7
PS1, Line 130: _
nit: from a cursory glance, prefixing static function names with `_` isn't very common in coreboot; […]
It's not about static functions. I used the _ prefix here when I needed a
basic version of the function that takes the `cap` offset as an argument.
Looking at the current implementation, the only name clash is with
pci_exp_enable_ltr(). So I could rename the first two functions here
without hassle. If that is preferred?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51328
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c5b8658f1fc8cec15e8b0824464c6fc9bee7e0e
Gerrit-Change-Number: 51328
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Fri, 12 Mar 2021 23:44:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment