Attention is currently required from: Jason Nien, Martin Roth, Matt DeVillier.
Felix Singer has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/86468?usp=email )
Change subject: mb/google/skyrim/var/frostflow: Set SYSTEM_TYPE_CONVERTIBLE ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/skyrim/Kconfig:
https://review.coreboot.org/c/coreboot/+/86468/comment/44477593_478f8a00?usp... : PS1, Line 33: select ACPI_S1_NOT_SUPPORTED : select AMD_FWM_POSITION_C20000_DEFAULT : select AMD_SOC_CONSOLE_UART : select BOARD_ROMSIZE_KB_16384 : select DISABLE_KEYBOARD_RESET_PIN : select DISABLE_SPI_FLASH_ROM_SHARING : select DRIVERS_GENERIC_GPIO_KEYS : select DRIVERS_GENERIC_MAX98357A : select DRIVERS_ACPI_THERMAL_ZONE : select DRIVERS_I2C_GENERIC : select DRIVERS_I2C_HID : select DRIVERS_I2C_NAU8825 : select DRIVERS_USB_HUB : select DRIVERS_UART_ACPI : select DRIVERS_PCIE_GENERIC : select DRIVERS_PCIE_RTD3_DEVICE : select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_BOARDID : select EC_GOOGLE_CHROMEEC_ESPI : select EC_GOOGLE_CHROMEEC_SKUID : select ELOG : select ELOG_GSMI : select FW_CONFIG : select FW_CONFIG_SOURCE_CHROMEEC_CBI : select GOOGLE_SMBIOS_MAINBOARD_VERSION : select HAS_RECOVERY_MRC_CACHE : select I2C_TPM : select MAINBOARD_HAS_CHROMEOS : select MAINBOARD_HAS_TPM2 : select MB_COMPRESS_RAMSTAGE_LZ4 : select PCIEXP_ASPM : select PCIEXP_CLK_PM : select PCIEXP_COMMON_CLOCK : select PCIEXP_L1_SUB_STATE : select SOC_AMD_MENDOCINO : select SOC_AMD_COMMON_BLOCK_I2C3_TPM_SHARED_WITH_PSP : select SOC_AMD_COMMON_BLOCK_USE_ESPI : select SOC_AMD_GFX_CACHE_VBIOS_IN_FMAP if CHROMEOS && RUN_FSP_GOP : select SYSTEM_TYPE_LAPTOP if !SYSTEM_TYPE_CONVERTIBLE : select TPM_GOOGLE_TI50
Could you add a patch on top that moves the selects under BOARD_GOOGLE_BASEBOARD_SKYRIM? That allows […]
Not a todo here, marking as resolved.