Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48862 )
Change subject: drivers/intel/gma: Rework brightness level includes ......................................................................
drivers/intel/gma: Rework brightness level includes
Make GFX0 device independent from brightness controls by removing the includes for common.asl and configure_brightness_levels.asl from gma.asl and moving them into default_brightness_levels.asl, which is what most boards include directly.
Also include these two files directly for the two boards which do not use the default brightness levels, but define their own.
Change-Id: Ie71bd5fc7acd926b7ce7da17fbc108670fd453e0 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/drivers/intel/gma/acpi/default_brightness_levels.asl M src/drivers/intel/gma/acpi/gma.asl M src/mainboard/roda/rv11/variants/rv11/include/acpi/brightness_levels.asl M src/mainboard/roda/rv11/variants/rw11/include/acpi/brightness_levels.asl 4 files changed, 9 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/48862/1
diff --git a/src/drivers/intel/gma/acpi/default_brightness_levels.asl b/src/drivers/intel/gma/acpi/default_brightness_levels.asl index 9e81741..7dadc42 100644 --- a/src/drivers/intel/gma/acpi/default_brightness_levels.asl +++ b/src/drivers/intel/gma/acpi/default_brightness_levels.asl @@ -4,6 +4,9 @@
Scope (GFX0) { + #include "configure_brightness_levels.asl" + #include "common.asl" + Name (BRIG, Package (0x12) { 100, /* default AC */ diff --git a/src/drivers/intel/gma/acpi/gma.asl b/src/drivers/intel/gma/acpi/gma.asl index c4ee2db..ad47cea 100644 --- a/src/drivers/intel/gma/acpi/gma.asl +++ b/src/drivers/intel/gma/acpi/gma.asl @@ -23,7 +23,4 @@ Offset (CONFIG_INTEL_GMA_BCLM_OFFSET), BCLM, CONFIG_INTEL_GMA_BCLM_WIDTH } - -#include "configure_brightness_levels.asl" -#include "common.asl" } diff --git a/src/mainboard/roda/rv11/variants/rv11/include/acpi/brightness_levels.asl b/src/mainboard/roda/rv11/variants/rv11/include/acpi/brightness_levels.asl index 638e659..972bee8 100644 --- a/src/mainboard/roda/rv11/variants/rv11/include/acpi/brightness_levels.asl +++ b/src/mainboard/roda/rv11/variants/rv11/include/acpi/brightness_levels.asl @@ -4,6 +4,9 @@
Scope (GFX0) { + #include <drivers/intel/gma/acpi/configure_brightness_levels.asl> + #include <drivers/intel/gma/acpi/common.asl> + Name (BRIG, Package (13) { 74, /* default AC */ diff --git a/src/mainboard/roda/rv11/variants/rw11/include/acpi/brightness_levels.asl b/src/mainboard/roda/rv11/variants/rw11/include/acpi/brightness_levels.asl index 2ad4521..a50e97a 100644 --- a/src/mainboard/roda/rv11/variants/rw11/include/acpi/brightness_levels.asl +++ b/src/mainboard/roda/rv11/variants/rw11/include/acpi/brightness_levels.asl @@ -4,6 +4,9 @@
Scope (GFX0) { + #include <drivers/intel/gma/acpi/configure_brightness_levels.asl> + #include <drivers/intel/gma/acpi/common.asl> + Name (BRIG, Package (13) { 74, /* default AC */