Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39997 )
Change subject: mb/google/rambi: Disable console output by default
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/...
File src/mainboard/google/rambi/Kconfig:
https://review.coreboot.org/c/coreboot/+/39997/1/src/mainboard/google/rambi/...
PS1, Line 81: config ENABLE_BUILTIN_COM1
Or rather: […]
the built-in COM1 is actually for the SoC, and console serial would likely be via the EC/servo, so there's not a perfectly causal relationship
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39997
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id6b2c28658aca03d8c5042d719a0f6f504c29288
Gerrit-Change-Number: 39997
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 01 Apr 2020 19:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment