Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39769 )
Change subject: nb/intel/haswell: Implement proper backlight PWM config
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe...
File src/northbridge/intel/haswell/gma.c:
https://review.coreboot.org/c/coreboot/+/39769/4/src/northbridge/intel/haswe...
PS4, Line 359: refclock / 128 / 100
Which of the two divisions goes first?
With the exception of assignments, all binary operators in C are left-associative,
i.e. you can read this from left to right like conventional math (well, the math I
learned, don't know how international it is).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39769
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17dfe1a3610d5e2918c617cf5d10896692fdccb3
Gerrit-Change-Number: 39769
Gerrit-PatchSet: 4
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 25 Mar 2020 10:56:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment