Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/38242 )
Change subject: gma panel config: Turn `internal display type` into a `panel port`
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/libgfxinit/+/38242/1/common/hw-gfx-gma-panel.a...
File common/hw-gfx-gma-panel.adb:
https://review.coreboot.org/c/libgfxinit/+/38242/1/common/hw-gfx-gma-panel.a...
PS1, Line 226: others
Where is `DP1 | HDMI1` ?
Hiding... more seriously, hardware with `Has_PP_Port_Select` doesn't
support the combination of those with a panel.
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/38242
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: Id3c78441857d07fb34274b9abd3ae6ea42909ff6
Gerrit-Change-Number: 38242
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 09 Jan 2020 13:13:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment