Hello build bot (Jenkins), Nico Huber, Michael Niewöhner, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45345
to look at the new patch set (#2).
Change subject: soc/intel/common/block: Move PRMRR options to CPU subfolder ......................................................................
soc/intel/common/block: Move PRMRR options to CPU subfolder
The PRMRR Kconfig symbols are located in the SGX subfolder. However, they are only used in `cpulib.c`, which lies within the CPU subfolder. Moreover, it seems that SGX isn't the only user of PRMRRs: there's an undocumented feature called C6DRAM, which apparently uses PRM as well.
Commit 1b89f5e (soc/intel/common/block/*/Kconfig: Guard options with if-blocks) made the PRMRR symbols only visible when the SoC selects SGX support with the `SOC_INTEL_COMMON_BLOCK_SGX` symbol. This resulted in `SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED` not being selected anymore, which caused boot failures in `cpulib.c`, function `get_prmrr_size`.
Move all PRMRR size Kconfig symbols from SGX to CPU, and rename them. Also, do not check for `SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_DISABLED` to determine whether PRMRR is disabled. Instead, check if the configured PRMRR size is zero, and exit if so. Finally, add `default 0` lines to the `SOC_INTEL_COMMON_BLOCK_SGX_PRMRR_SIZE` option, so that it always has a defined value, Prefer explicitness rather than less redundancy.
Change-Id: I27f1d3741e8e3755130078c79ab13ae8873354fc Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/common/block/cpu/Kconfig M src/soc/intel/common/block/cpu/cpulib.c M src/soc/intel/common/block/sgx/Kconfig 3 files changed, 57 insertions(+), 50 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/45345/2