Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33448 )
Change subject: mb/google/octopus: expose get_board_sku as global
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa...
File src/mainboard/google/octopus/mainboard.c:
https://review.coreboot.org/#/c/33448/1/src/mainboard/google/octopus/mainboa...
PS1, Line 121: __weak
Done, thank you!
My last argument is to have common function in the same name like this get_board_sku / variant_board_sku and it would be good for partners to refer as well and be good once we have plan to come out a doc for topic like 'board customization tips in a baseboard of coreboot'.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33448
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1fb7b5eeac48f2cd9c24fa1d3ac3fe4b390762d2
Gerrit-Change-Number: 33448
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quantatw.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Kevin Chiu
kevin.chiu@quanta.corp-partner.google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: Sheng-Liang Pan
sheng-liang.pan@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 18 Jun 2019 00:55:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Marco Chen
marcochen@google.com
Comment-In-Reply-To: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-MessageType: comment