build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: mediatek/mt8183: Use calibration result do fast calibration ......................................................................
Patch Set 10:
(16 comments)
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 951: (dly_coarse_large_rodt_p1 << 4) | (dly_coarse_large_rodt_p1 << 12) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 952: (dly_coarse_large_rodt_p1 << 20) | (dly_coarse_large_rodt_p1 << 28)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 957: (dly_coarse_0p5t_rodt_p1 << 4) | (dly_coarse_0p5t_rodt_p1 << 12) | line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 958: (dly_coarse_0p5t_rodt_p1 << 20) | (dly_coarse_0p5t_rodt_p1 << 28)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 960: for (u8 dly_fine_xt = 0; dly_fine_xt < DQS_GW_FINE_END; dly_fine_xt += 4) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1004: dly_coarse_large, dly_coarse_0p5t, pass_begin, pass_count, line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1611: vref_dly[index].win_center = params->tx_win_center[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1612: vref_dly[index].best_first = params->tx_first_pass[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1613: vref_dly[index].best_last = params->tx_last_pass[chn][rank][index]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1624: center_dly[byte].min_center = vref_dly[index].win_center; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1626: center_dly[byte].max_center = vref_dly[index].win_center; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1788: dramc_set_tx_best_dly(chn, rank, bypass_tx,vref_dly.perbit_dly, type, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1826: if (have_calibration_params(params) && (type == RX_WIN_RD_DQC || type == RX_WIN_TEST_ENG)) { line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1829: win_perbit[bit].best_first = params->rx_firspass[chn][rank][bit]; line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1843: /* pass window bigger than 7, consider as real pass window */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/35164/10/src/soc/mediatek/mt8183/dr... PS10, Line 1871: if (dramk_calc_best_vref(type, vref_use, &vref_dly, win_perbit, &win_min_max)) line over 96 characters