Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48517 )
Change subject: soc/amd/cezanne: add caching setup in bootblock
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48517/2/src/soc/amd/cezanne/bootblo...
File src/soc/amd/cezanne/bootblock.c:
https://review.coreboot.org/c/coreboot/+/48517/2/src/soc/amd/cezanne/bootblo...
PS2, Line 60: CONFIG_ROM_SIZE
the symbols needed by CAR_CACHE_ROM_SIZE are likely not available, since this soc doesn't use CAR. […]
since i had to manually rebase this patch anyway, I added a TODO for this; haven't fully figured out how this should be done with only having a brief look at the manual. But for now it works well enough
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fc158518cf9534ab9727f3305abeb4b34049e76
Gerrit-Change-Number: 48517
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 11 Dec 2020 21:56:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment