Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46393 )
Change subject: soc/mediatek/mt8192: Add dpm loader
......................................................................
Patch Set 35:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46393/35/src/soc/mediatek/mt8192/dp...
File src/soc/mediatek/mt8192/dpm.c:
https://review.coreboot.org/c/coreboot/+/46393/35/src/soc/mediatek/mt8192/dp...
PS35, Line 29: ret = -1;
Simply write
return -1;
here, and remove the 'ret' variable.
https://review.coreboot.org/c/coreboot/+/46393/35/src/soc/mediatek/mt8192/dp...
PS35, Line 31: ret = -2;
return -2 (Actually I wonder if we can also return -1 here since mtlib_load_and_run() should have printed the file name in the error message)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I16b341ad63940b45b886c4a7fd733c1970624e40
Gerrit-Change-Number: 46393
Gerrit-PatchSet: 35
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Xixi Chen
xixi.chen@mediatek.corp-partner.google.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Thu, 03 Dec 2020 09:57:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment