Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51711 )
Change subject: soc/amd/cezanne: select HAVE_EM100_SUPPORT
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/cezanne/Kconfig:
https://review.coreboot.org/c/coreboot/+/51711/comment/894be24b_25436a8a
PS1, Line 25: HAVE_EM100_SUPPORT
This should be defined on the mainboard. […]
currently it's at soc level and i'd say that the 16mhz in the common chipset code should be a safe frequency. see src/soc/amd/common/block/spi/fch_spi.c:fch_spi_config_em100_modes()
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51711
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5dec9ce69628ca3623b5009d47f4b3dc020a3dad
Gerrit-Change-Number: 51711
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 16:05:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment