Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38719 )
Change subject: sb/intel/common/firmware: add ifd update option ......................................................................
Patch Set 3:
(6 comments)
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Kconfig:
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 42: update Update
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 47: of
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... File src/southbridge/intel/common/firmware/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 31: -new `-new` doesn't carry much information, how about `descriptor-newlayout.bin`? or simply `descriptor.bin`?
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 32: $(IFDTOOL)
Missing dependencies: $(CONFIG_IFD_BIN_PATH) $(CONFIG_IFD_BIN_LAYOUT_PATH)
Note that they will need $(strip_quotes ) beforehand.
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 34: $(CONFIG_IFD_BIN_PATH) Could use $< if you make it the first prerequisite.
https://review.coreboot.org/c/coreboot/+/38719/3/src/southbridge/intel/commo... PS3, Line 39: $(obj)/descriptor-new.bin Use $@ here to make clear that it's the target.