Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35014 )
Change subject: Move and rename ARCH_STAGE_HAS_xxx_SECTION rules ......................................................................
Patch Set 5:
(3 comments)
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld@128 PS4, Line 128: #if ENV_STAGE_HAS_BSS_SECTION
#if ENV_STAGE_HAS_BSS_SECTION && !ENV_CACHE_AS_RAM ?
CB:35016
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld@129 PS4, Line 129: .bss . : {
Not good.. .bss ends up inside execute-in-place bootblock with CB:35003. […]
Ack
https://review.coreboot.org/c/coreboot/+/35014/4/src/lib/program.ld@141 PS4, Line 141: #if ENV_STAGE_HAS_HEAP_SECTION
likewise
Ack