Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33661 )
Change subject: vendorcode/google: load sar config from CBFS first then VPD ......................................................................
Patch Set 1:
reply to Hung-Te: The reason for this CL is to set WIFI SAR in CBFS to be higher priority then VPD in RO. As a result, we don't consider to update FW RO actually; we update CBFS in RW to override the SAR value instead if we need to.
Regarding review effort, no matter in factory test or CBFS we all need someone to review so there is no difference. There are others in VPD RO like region and MAC so ODM should take responsibility for them.
reply to Furquan: The main reason for me to keep VPD is to let ODM to do more and reduce the dependency to FW. For example, there is a next wave device like laser which is just new SKU IDs of phaser360. Since phaser360 was shipped, the cherry-pick policy to model.yaml of this device is strict which introduce troubles for development cycle if we can only set SAR in CBFS. Especially SAR value will be decided when ME is locked down (ex: DVT).
No strong insistence but would like to share why let ODM team to control is good for next wave projects.