Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40247 )
Change subject: soc/amd/picasso/i2c: don't initialize I2C4 as master and refactor code
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
I'll +2 once https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+... lands.
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c
File src/soc/amd/picasso/i2c.c:
https://review.coreboot.org/c/coreboot/+/40247/4/src/soc/amd/picasso/i2c.c@2...
PS4, Line 24: []
If the array size was "I2C_MASTER_DEV_COUNT + I2C_SLAVE_DEV_COUNT", would the _Static_assert still b […]
I left it this way so that if the #defines are changed or the array is changed it will fail. Explicitly setting the array catches the case where the number of elements listed is less.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40247
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I397b074ef9c14bf6a4f6680696582f5173a5d0d3
Gerrit-Change-Number: 40247
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Magf -
magf@bitland.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 15 Apr 2020 15:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment