Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45059 )
Change subject: soc/amd/picasso: pass verstage timestamps to x86
......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl...
File src/soc/amd/picasso/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/45059/10/src/soc/amd/picasso/bootbl...
PS10, Line 129: #if CONFIG(VBOOT)
Because _transfer_buffer is guarded with CONFIG(VBOOT) in soc/amd/picasso/memlayout_x86.ld. […]
I had thought we worked around needing the #if. There's a DECLARE_REGION(transfer_buffer) in include/symbols.h which should provide the declaration of the symbols. The CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK) guard below will not need to link this code because of dead code elimination. It should work without?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45059
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5e89bb54f478153fb40ba51b5ab61fa20af3b99a
Gerrit-Change-Number: 45059
Gerrit-PatchSet: 10
Gerrit-Owner: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 29 Oct 2020 22:26:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won
khwon@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment